----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31369/#review80555 -----------------------------------------------------------
Thanks for the patch. A few more minor comments. clients/src/main/java/org/apache/kafka/common/serialization/IntegerDeserializer.java <https://reviews.apache.org/r/31369/#comment130586> Perhaps we can put b & 0xFF in brackets to make the precedence clear? clients/src/test/java/org/apache/kafka/common/serialization/SerializationTest.java <https://reviews.apache.org/r/31369/#comment130579> Perhaps we can combine the two tests. We don't need to test null twice. Instead of deplicating the test code for positive and negative values, we can probably just to put the test code in a loop and iterate it twice. examples/src/main/java/kafka/examples/Producer.java <https://reviews.apache.org/r/31369/#comment130583> record -> message - Jun Rao On April 17, 2015, 10:09 p.m., Ashish Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31369/ > ----------------------------------------------------------- > > (Updated April 17, 2015, 10:09 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1982 > https://issues.apache.org/jira/browse/KAFKA-1982 > > > Repository: kafka > > > Description > ------- > > KAFKA-1982: change kafka.examples.Producer to use the new java producer > > > Diffs > ----- > > > clients/src/main/java/org/apache/kafka/common/serialization/IntegerDeserializer.java > PRE-CREATION > > clients/src/main/java/org/apache/kafka/common/serialization/IntegerSerializer.java > PRE-CREATION > > clients/src/test/java/org/apache/kafka/common/serialization/SerializationTest.java > f5cd61c1aa9433524da0b83826a766389de68a0b > examples/README 53db6969b2e2d49e23ab13283b9146848e37434e > examples/src/main/java/kafka/examples/Consumer.java > 13135b954f3078eeb7394822b0db25470b746f03 > examples/src/main/java/kafka/examples/KafkaConsumerProducerDemo.java > 1239394190fe557e025fbd8f3803334402b0aeea > examples/src/main/java/kafka/examples/Producer.java > 96e98933148d07564c1b30ba8e805e2433c2adc8 > examples/src/main/java/kafka/examples/SimpleConsumerDemo.java > 0d66fe5f8819194c8624aed4a21105733c20cc8e > > Diff: https://reviews.apache.org/r/31369/diff/ > > > Testing > ------- > > > Thanks, > > Ashish Singh > >
