----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31369/#review80607 -----------------------------------------------------------
There seems to be a bunch of checkstyle failures. Could you address those? ./gradlew -Dtest.single=SerializationTest cleanTest client:test [ant:checkstyle] /Users/junrao/intellij/kafka/clients/src/main/java/org/apache/kafka/common/serialization/IntegerDeserializer.java:17:8: Unused import - java.nio.ByteBuffer. [ant:checkstyle] /Users/junrao/intellij/kafka/clients/src/main/java/org/apache/kafka/common/serialization/IntegerDeserializer.java:27: if at indentation level 6 not at correct indentation, 8 [ant:checkstyle] /Users/junrao/intellij/kafka/clients/src/main/java/org/apache/kafka/common/serialization/IntegerDeserializer.java:28: if child at indentation level 8 not at correct indentation, 12 [ant:checkstyle] /Users/junrao/intellij/kafka/clients/src/main/java/org/apache/kafka/common/serialization/IntegerDeserializer.java:29: if at indentation level 6 not at correct indentation, 8 [ant:checkstyle] /Users/junrao/intellij/kafka/clients/src/main/java/org/apache/kafka/common/serialization/IntegerDeserializer.java:30: if child at indentation level 8 not at correct indentation, 12 [ant:checkstyle] /Users/junrao/intellij/kafka/clients/src/main/java/org/apache/kafka/common/serialization/IntegerDeserializer.java:32: if rcurly at indentation level 6 not at correct indentation, 8 [ant:checkstyle] /Users/junrao/intellij/kafka/clients/src/main/java/org/apache/kafka/common/serialization/IntegerDeserializer.java:34: method def child at indentation level 6 not at correct indentation, 8 [ant:checkstyle] /Users/junrao/intellij/kafka/clients/src/main/java/org/apache/kafka/common/serialization/IntegerDeserializer.java:35: for at indentation level 6 not at correct indentation, 8 [ant:checkstyle] /Users/junrao/intellij/kafka/clients/src/main/java/org/apache/kafka/common/serialization/IntegerDeserializer.java:36: for child at indentation level 8 not at correct indentation, 12 [ant:checkstyle] /Users/junrao/intellij/kafka/clients/src/main/java/org/apache/kafka/common/serialization/IntegerDeserializer.java:37: for child at indentation level 8 not at correct indentation, 12 [ant:checkstyle] /Users/junrao/intellij/kafka/clients/src/main/java/org/apache/kafka/common/serialization/IntegerDeserializer.java:37:15: Unnecessary parentheses around assignment right-hand side. [ant:checkstyle] /Users/junrao/intellij/kafka/clients/src/main/java/org/apache/kafka/common/serialization/IntegerDeserializer.java:38: for rcurly at indentation level 6 not at correct indentation, 8 [ant:checkstyle] /Users/junrao/intellij/kafka/clients/src/main/java/org/apache/kafka/common/serialization/IntegerDeserializer.java:39: method def child at indentation level 6 not at correct indentation, 8 [ant:checkstyle] /Users/junrao/intellij/kafka/clients/src/main/java/org/apache/kafka/common/serialization/IntegerSerializer.java:24: if at indentation level 6 not at correct indentation, 8 [ant:checkstyle] /Users/junrao/intellij/kafka/clients/src/main/java/org/apache/kafka/common/serialization/IntegerSerializer.java:25: if child at indentation level 8 not at correct indentation, 12 [ant:checkstyle] /Users/junrao/intellij/kafka/clients/src/main/java/org/apache/kafka/common/serialization/IntegerSerializer.java:27: method def child at indentation level 6 not at correct indentation, 8 [ant:checkstyle] /Users/junrao/intellij/kafka/clients/src/main/java/org/apache/kafka/common/serialization/IntegerSerializer.java:28: array initialization child at indentation level 8 not at correct indentation, 10 [ant:checkstyle] /Users/junrao/intellij/kafka/clients/src/main/java/org/apache/kafka/common/serialization/IntegerSerializer.java:29: array initialization child at indentation level 8 not at correct indentation, 10 [ant:checkstyle] /Users/junrao/intellij/kafka/clients/src/main/java/org/apache/kafka/common/serialization/IntegerSerializer.java:30: array initialization child at indentation level 8 not at correct indentation, 10 [ant:checkstyle] /Users/junrao/intellij/kafka/clients/src/main/java/org/apache/kafka/common/serialization/IntegerSerializer.java:31: method call child at indentation level 8 not at correct indentation, 10 [ant:checkstyle] /Users/junrao/intellij/kafka/clients/src/main/java/org/apache/kafka/common/serialization/IntegerSerializer.java:35: method def modifier at indentation level 2 not at correct indentation, 4 :clients:checkstyleMain FAILED - Jun Rao On April 18, 2015, midnight, Ashish Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31369/ > ----------------------------------------------------------- > > (Updated April 18, 2015, midnight) > > > Review request for kafka. > > > Bugs: KAFKA-1982 > https://issues.apache.org/jira/browse/KAFKA-1982 > > > Repository: kafka > > > Description > ------- > > KAFKA-1982: change kafka.examples.Producer to use the new java producer > > > Diffs > ----- > > > clients/src/main/java/org/apache/kafka/common/serialization/IntegerDeserializer.java > PRE-CREATION > > clients/src/main/java/org/apache/kafka/common/serialization/IntegerSerializer.java > PRE-CREATION > > clients/src/test/java/org/apache/kafka/common/serialization/SerializationTest.java > f5cd61c1aa9433524da0b83826a766389de68a0b > examples/README 53db6969b2e2d49e23ab13283b9146848e37434e > examples/src/main/java/kafka/examples/Consumer.java > 13135b954f3078eeb7394822b0db25470b746f03 > examples/src/main/java/kafka/examples/KafkaConsumerProducerDemo.java > 1239394190fe557e025fbd8f3803334402b0aeea > examples/src/main/java/kafka/examples/Producer.java > 96e98933148d07564c1b30ba8e805e2433c2adc8 > examples/src/main/java/kafka/examples/SimpleConsumerDemo.java > 0d66fe5f8819194c8624aed4a21105733c20cc8e > > Diff: https://reviews.apache.org/r/31369/diff/ > > > Testing > ------- > > > Thanks, > > Ashish Singh > >
