+1 non-binding. Thanks for all the work on this Jiangjie! Aditya -- see discussion of partitionsFor() API, which needs to also use one of those timeouts, and is a fetch rather than a send since it's just getting metadata.
-Ewen On Tue, Jun 2, 2015 at 4:44 PM, Aditya Auradkar < aaurad...@linkedin.com.invalid> wrote: > +1 (non-binding). > > One minor comment. Should we rename "max.block.ms" to "max.send.block.ms"? > Something that indicates that it is being applied to the "send" API methods > exposed by KafkaProducer. > > Aditya > ________________________________________ > From: Joel Koshy [jjkosh...@gmail.com] > Sent: Tuesday, June 02, 2015 4:36 PM > To: dev@kafka.apache.org > Subject: Re: [VOTE] KIP-19 Add a request timeout to NetworkClient > > +1 > > On Tue, Jun 02, 2015 at 10:13:11PM +0000, Jiangjie Qin wrote: > > Ah, yes. Just changed it to ³request.timeout.ms². > > > > Thanks. > > > > Jiangjie (Becket) Qin > > > > On 6/2/15, 2:31 PM, "Jun Rao" <j...@confluent.io> wrote: > > > > >The wiki references "network.request.timeout.ms" in ProducerConfig. It > > >should be "request.timeout.ms", right? > > > > > >Thanks, > > > > > >Jun > > > > > >On Tue, Jun 2, 2015 at 2:06 PM, Jiangjie Qin <j...@linkedin.com.invalid > > > > >wrote: > > > > > >> Hi folks, > > >> > > >> Thanks a lot for all the input and help. It looks we do not have > further > > >> concerns on KIP-19. I¹ve updated the wiki page, let¹s vote! > > >> > > >> > > >> > > >> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-19+-+Add+a+request+ > > >>timeout+to+NetworkClient > > >> > > >> Thanks, > > >> > > >> Jiangjie (Becket) Qin > > >> > > > > -- Thanks, Ewen
