> On July 7, 2015, 12:36 a.m., Jun Rao wrote: > > core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala, line 50 > > <https://reviews.apache.org/r/35820/diff/2/?file=997781#file997781line50> > > > > This seems to be specific to testIsrAfterBrokerShutDownAndJoinsBack. > > Could we move it there?
KAFKA-972 also uses this. I think its best to have it initialized just once in setup. Let me know if you think otherwise. > On July 7, 2015, 12:36 a.m., Jun Rao wrote: > > core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala, line 143 > > <https://reviews.apache.org/r/35820/diff/2/?file=997781#file997781line143> > > > > Can this be private? It should be. Thanks for pointing out. - Ashish ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35820/#review90605 ----------------------------------------------------------- On July 7, 2015, 5:04 a.m., Ashish Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35820/ > ----------------------------------------------------------- > > (Updated July 7, 2015, 5:04 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1367 > https://issues.apache.org/jira/browse/KAFKA-1367 > > > Repository: kafka > > > Description > ------- > > KAFKA-1367: Broker topic metadata not kept in sync with ZooKeeper > > > Diffs > ----- > > core/src/main/scala/kafka/common/TopicAndPartition.scala > df3db912f5daef6a25b4b2dd2220d2cc3795bce6 > core/src/main/scala/kafka/controller/KafkaController.scala > 36350579b16027359d237b64699003358704ac6f > core/src/main/scala/kafka/utils/ReplicationUtils.scala > 60687332b4c9bee4d4c0851314cfb4b02d5d3489 > core/src/main/scala/kafka/utils/ZkUtils.scala > 78475e3d5ec477cef00caeaa34ff2d196466be96 > core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala > 995b05901491bb0dbf0df210d44bd1d7f66fdc82 > core/src/test/scala/unit/kafka/utils/ReplicationUtilsTest.scala > c96c0ffd958d63c09880d436b2e5ae96f51ead36 > > Diff: https://reviews.apache.org/r/35820/diff/ > > > Testing > ------- > > Tested on a test cluster with 3 Kafka brokers > > > Thanks, > > Ashish Singh > >
