----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36590/#review92294 -----------------------------------------------------------
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java (line 1072) <https://reviews.apache.org/r/36590/#comment146357> why did you put this method variable as final? - Edward Ribeiro On July 20, 2015, 5:44 p.m., Ashish Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36590/ > ----------------------------------------------------------- > > (Updated July 20, 2015, 5:44 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2275 > https://issues.apache.org/jira/browse/KAFKA-2275 > > > Repository: kafka > > > Description > ------- > > Add logic to get all topics when needMetadataForAllTopics is set on metadata > > > Return metadata for all topics if empty list is passed to partitionsFor > > > KAFKA-2275: Add a "Map<String, List<PartitionInfo>> partitionsFor(String... > topics)" API to the new consumer > > > Diffs > ----- > > clients/src/main/java/org/apache/kafka/clients/Metadata.java > 0387f2602c93a62cd333f1b3c569ca6b66b5b779 > clients/src/main/java/org/apache/kafka/clients/NetworkClient.java > 48fe7961e2215372d8033ece4af739ea06c6457b > clients/src/main/java/org/apache/kafka/clients/consumer/Consumer.java > 252b759c0801f392e3526b0f31503b4b8fbf1c8a > clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java > bea3d737c51be77d5b5293cdd944d33b905422ba > clients/src/main/java/org/apache/kafka/clients/consumer/MockConsumer.java > c14eed1e95f2e682a235159a366046f00d1d90d6 > > clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkClient.java > 9517d9d0cd480d5ba1d12f1fde7963e60528d2f8 > clients/src/main/java/org/apache/kafka/common/Cluster.java > 60594a7dce90130911a626ea80cf80d815aeb46e > core/src/test/scala/integration/kafka/api/ConsumerTest.scala > 3eb5f95731a3f06f662b334ab2b3d0ad7fa9e1ca > > Diff: https://reviews.apache.org/r/36590/diff/ > > > Testing > ------- > > > Thanks, > > Ashish Singh > >
