> On July 21, 2015, 2:43 p.m., Ismael Juma wrote: > > core/src/main/scala/kafka/server/OffsetManager.scala, line 454 > > <https://reviews.apache.org/r/36548/diff/2/?file=1013441#file1013441line454> > > > > Is `topicData` guaranteed to have a key for `topic`? If not, it's > > better to do `topicData.get(topic)` to avoid the `NoSuchElementException`.
Yes it is guranteed. See ZkUtils.getPartitionAssignmentForTopics. - Grant ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36548/#review92406 ----------------------------------------------------------- On July 16, 2015, 6:04 p.m., Grant Henke wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36548/ > ----------------------------------------------------------- > > (Updated July 16, 2015, 6:04 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2336 > https://issues.apache.org/jira/browse/KAFKA-2336 > > > Repository: kafka > > > Description > ------- > > Fix Scala style > > > Diffs > ----- > > core/src/main/scala/kafka/server/OffsetManager.scala > 47b6ce93da320a565435b4a7916a0c4371143b8a > > Diff: https://reviews.apache.org/r/36548/diff/ > > > Testing > ------- > > > Thanks, > > Grant Henke > >
