+1 (binding) Agree with Ismael. We may not want to rush to push the PR right away. Having said that, if it works well with say, 10 patches, I'd consider that enough to require the new JIRAs to submit patches using the PRs instead.
Thanks, Neha On Tue, Jul 21, 2015 at 8:19 AM, Sriharsha Chintalapani < harsh...@fastmail.fm> wrote: > +1 . I think phasing out a good idea but rather than x months we should > move to github PRs for any new JIRAs that are not already in review board. > For the JIRA’s that are in review board we can continue to use that until > they merged in. > > -Harsha > > > On July 21, 2015 at 8:11:17 AM, Ashish Singh (asi...@cloudera.com) wrote: > > +1 non-binding. > > A suggestion, we should try to phase out old system of reviews gradually, > instead of forcing it over a night. Maybe a time bound switch? We can say > like in x months from now we will completely move to PRs? > > On Tuesday, July 21, 2015, Ismael Juma <ism...@juma.me.uk> wrote: > > > Hi all, > > > > I would like to start a vote on switching to GitHub pull requests for new > > contributions. To be precise, the vote is on whether we should: > > > > * Update the documentation to tell users to use pull requests instead of > > patches and Review Board (i.e. merge KAFKA-2321 and KAFKA-2349) > > * Use pull requests for new contributions > > > > In a previous discussion[1], everyone that participated was in favour. > It's > > also worth reading the "Contributing Code Changes" wiki page[2] (if you > > haven't already) to understand the flow. > > > > A number of pull requests have been merged in the last few weeks to test > > this flow and I believe it's working well enough. As usual, there is > always > > room for improvement and I expect is to tweak things as time goes on. > > > > The main downside of using GitHub pull requests is that we don't have > write > > access to https://github.com/apache/kafka. That means that we rely on > > commit hooks to close integrated pull requests (the merge script takes > care > > of formatting the message so that this happens) and the PR creator or > > Apache Infra to close pull requests that are not integrated. > > > > Regarding existing contributions, I think it's up to the contributor to > > decide whether they want to resubmit it as a pull request or not. I > expect > > that there will be a transition period where the old and new way will > > co-exist. But that can be discussed separately. > > > > The vote will run for 72 hours. > > > > +1 (non-binding) from me. > > > > Best, > > Ismael > > > > [1] http://search-hadoop.com/m/uyzND1N6CDH1DUc82 > > [2] > > > https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes > > > > > -- > Ashish 🎤h > -- Thanks, Neha
