[ https://issues.apache.org/jira/browse/KAFKA-2389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14662543#comment-14662543 ]
Jason Gustafson commented on KAFKA-2389: ---------------------------------------- [~becket_qin] I'm definitely in favor of removing CommitType if we can find an intuitive way to express the two behaviors. Are you suggesting above that if the user passes null for the callback then the commit is synchronous? Or would the methods which don't accept a callback be treated as synchronous? > CommitType seems not necessary in commit(). > ------------------------------------------- > > Key: KAFKA-2389 > URL: https://issues.apache.org/jira/browse/KAFKA-2389 > Project: Kafka > Issue Type: Sub-task > Reporter: Jiangjie Qin > Assignee: Jiangjie Qin > > The CommitType does not seem to be necessary in for commit(), it can be > inferred from whether user passed in a callback or not. -- This message was sent by Atlassian JIRA (v6.3.4#6332)