[ 
https://issues.apache.org/jira/browse/KAFKA-2389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14662618#comment-14662618
 ] 

Jiangjie Qin commented on KAFKA-2389:
-------------------------------------

[~gwenshap], we talked with [~ewencp] about this before, my understanding of 
the reason future does not quite apply here is that KafkaConsumer is single 
threaded, so it is a little bit weird for a thread to call future.get() and 
meanwhile have to complete the future by itself.

> CommitType seems not necessary in commit().
> -------------------------------------------
>
>                 Key: KAFKA-2389
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2389
>             Project: Kafka
>          Issue Type: Sub-task
>            Reporter: Jiangjie Qin
>            Assignee: Jiangjie Qin
>
> The CommitType does not seem to be necessary in for commit(), it can be 
> inferred from whether user passed in a callback or not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to