[ 
https://issues.apache.org/jira/browse/KAFKA-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14698882#comment-14698882
 ] 

ASF GitHub Bot commented on KAFKA-2436:
---------------------------------------

GitHub user lindong28 opened a pull request:

    https://github.com/apache/kafka/pull/142

    KAFKA-2436; log.retention.hours should be honored by LogManager

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lindong28/kafka KAFKA-2436

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/142.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #142
    
----
commit a713d45ad4ed59440be020cc6c74efbeb2bbe54b
Author: Dong Lin <lindon...@gmail.com>
Date:   2015-08-16T23:11:58Z

    KAFKA-2436; log.retention.hours should be honored by LogManager

----


> log.retention.hours should be honored by LogManager
> ---------------------------------------------------
>
>                 Key: KAFKA-2436
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2436
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Dong Lin
>            Assignee: Dong Lin
>
> Currently log.retention.hours is used to calculate 
> KafkaConfig.logRetentionTimeMillis. But it is not used in LogManager to 
> decide when to delete a log. LogManager is only using the log.retention.ms in 
> the broker configuration.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to