[
https://issues.apache.org/jira/browse/KAFKA-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14699986#comment-14699986
]
ASF GitHub Bot commented on KAFKA-2436:
---------------------------------------
GitHub user lindong28 reopened a pull request:
https://github.com/apache/kafka/pull/142
KAFKA-2436; log.retention.hours should be honored by LogManager
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lindong28/kafka KAFKA-2436
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/142.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #142
----
commit a713d45ad4ed59440be020cc6c74efbeb2bbe54b
Author: Dong Lin <lindon...@gmail.com>
Date: 2015-08-16T23:11:58Z
KAFKA-2436; log.retention.hours should be honored by LogManager
commit a8436f778bbdc498cdae741a74c33296065d0b21
Author: Dong Lin <lindon...@gmail.com>
Date: 2015-08-17T15:30:14Z
A few other configurations should also be propagated to LogManager
commit ea44479abf305aa6926a1f6b2592c52216aa334f
Author: Dong Lin <lindon...@gmail.com>
Date: 2015-08-17T17:31:47Z
remove unnecessary type conversion
commit d634339fbb4daa0dfe112c6beea0751878613fa2
Author: Dong Lin <lindon...@gmail.com>
Date: 2015-08-17T17:57:43Z
move logRetentionTimeMillis to the group of Log Configuration in code
----
> log.retention.hours should be honored by LogManager
> ---------------------------------------------------
>
> Key: KAFKA-2436
> URL: https://issues.apache.org/jira/browse/KAFKA-2436
> Project: Kafka
> Issue Type: Bug
> Reporter: Dong Lin
> Assignee: Dong Lin
>
> Currently log.retention.hours is used to calculate
> KafkaConfig.logRetentionTimeMillis. But it is not used in LogManager to
> decide when to delete a log. LogManager is only using the log.retention.ms in
> the broker configuration.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
