[
https://issues.apache.org/jira/browse/KAFKA-2702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14979753#comment-14979753
]
Grant Henke commented on KAFKA-2702:
------------------------------------
Looking into this a bit more...
{quote}
Try printing ConsumerConfig parameters and see the mandatory group.id show up
as #15.
{quote}
There is an issue in ConfigDef where _NO_DEFAULT_VALUE = new String("")_,
however an empty string is actually a valid default value. Later on in the html
output, there is also an issue where null is interpreted as NO_DEFAULT_VALUE.
Null could also be a valid default.
This may also be an html output issue. If there is a default, its just empty
string (""), maybe we should print that. Many of the string parameters have a
default of "".
{quote}
or perhaps adding a "REQUIRED" category that gets printed first no matter
{quote}
There is a "required" field in ConfigKey. Adding that as a column to the table
is a good idea.
{quote}
Aren't things without default required?
{quote}
There are many optional parameters that don't have a default, but are not
required. Especially with the addition of many of the SSL parameters.
I think what we are looking for it prioritizing parameters that are required
and have no default. I will submit a patch, fixing the issues mentioned above
and adjusting the sort with that change, and we can discuss if its actually an
improvement over what exists.
> ConfigDef toHtmlTable() sorts in a way that is a bit confusing
> --------------------------------------------------------------
>
> Key: KAFKA-2702
> URL: https://issues.apache.org/jira/browse/KAFKA-2702
> Project: Kafka
> Issue Type: Bug
> Reporter: Gwen Shapira
>
> Because we put everything without default first (without prioritizing),
> critical parameters get placed below low priority ones when they both have
> no defaults. Some parameters are without default and optional (SASL server in
> ConsumerConfig for instance).
> Try printing ConsumerConfig parameters and see the mandatory group.id show up
> as #15.
> I suggest sorting the no-default parameters by priority as well, or perhaps
> adding a "REQUIRED" category that gets printed first no matter what.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
