[
https://issues.apache.org/jira/browse/KAFKA-2702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14980817#comment-14980817
]
Grant Henke commented on KAFKA-2702:
------------------------------------
[~jkreps] You are right, that _required_ was added in
[KAFKA-1845|https://issues.apache.org/jira/browse/KAFKA-1845]. The addition was
not discussed in the jira or [patch
reviews|https://reviews.apache.org/r/30126/]. [~abiletskyi] do you have an
insight?
I do like the idea of explicitly providing a good default for any optional
argument in the configuration definition. But I don't have too strong of a
feeling either way. If we do revert the addition of _required_, the newly added
SSL and Kerberos configs look like they might need to be reviewed/updated. They
leverage _required=false_ quite a bit.
> ConfigDef toHtmlTable() sorts in a way that is a bit confusing
> --------------------------------------------------------------
>
> Key: KAFKA-2702
> URL: https://issues.apache.org/jira/browse/KAFKA-2702
> Project: Kafka
> Issue Type: Bug
> Reporter: Gwen Shapira
> Assignee: Grant Henke
> Attachments: ConsumerConfig-After.html, ConsumerConfig-Before.html
>
>
> Because we put everything without default first (without prioritizing),
> critical parameters get placed below low priority ones when they both have
> no defaults. Some parameters are without default and optional (SASL server in
> ConsumerConfig for instance).
> Try printing ConsumerConfig parameters and see the mandatory group.id show up
> as #15.
> I suggest sorting the no-default parameters by priority as well, or perhaps
> adding a "REQUIRED" category that gets printed first no matter what.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
