[
https://issues.apache.org/jira/browse/KAFKA-4379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15636248#comment-15636248
]
ASF GitHub Bot commented on KAFKA-4379:
---------------------------------------
GitHub user dguy opened a pull request:
https://github.com/apache/kafka/pull/2103
KAFKA-4379: Remove caching of dirty and removed keys from StoreChangeLogger
The `StoreChangeLogger` currently keeps a cache of dirty and removed keys
and will batch the changelog records such that we don't send a record for each
update. However, with KIP-63 this is unnecessary as the batching and de-duping
is done by the caching layer. Further, the `StoreChangeLogger` relies on
`context.timestamp()` which is likely to be incorrect when caching is enabled
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dguy/kafka store-change-logger
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/2103.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2103
----
commit 9acd0cf3521b9fabec7b53fe147f445a6bf82b5a
Author: Damian Guy <[email protected]>
Date: 2016-11-04T12:36:59Z
remove caching from StoreChangeLogger
----
> Remove caching of dirty and removed keys from StoreChangeLogger
> ---------------------------------------------------------------
>
> Key: KAFKA-4379
> URL: https://issues.apache.org/jira/browse/KAFKA-4379
> Project: Kafka
> Issue Type: Improvement
> Components: streams
> Affects Versions: 0.10.1.0
> Reporter: Damian Guy
> Assignee: Damian Guy
> Priority: Minor
> Fix For: 0.10.1.1
>
>
> The StoreChangeLogger currently keeps a cache of dirty and removed keys and
> will batch the changelog records such that we don't send a record for each
> update. However, with KIP-63 this is unnecessary as the batching and
> de-duping is done by the caching layer. Further, the StoreChangeLogger relies
> on context.timestamp() which is likely to be incorrect when caching is enabled
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
