I agree, that we should not duplicate functionality. However, I am worried, that a non-streams users using the offset reset tool might delete topics unintentionally (even if the changes are pretty small). Also, currently the stream reset tool required Zookeeper while the offset reset tool does not -- I don't think we should add this dependency to the offset reset tool.
Thus, it think it might be better to keep both tools, but internally rewrite the streams reset entry class, to reuse as much as possible from the offset reset tool. Ie. the streams tool would be a wrapper around the offset tool and add some functionality it needs that is Streams specific. I also think, that keeping separate tools for consumers and streams is a good thing. We might want to add new features that don't apply to plain consumers -- note, a Streams applications is more than just a client. WDYT? Would be good to get some feedback from others, too. -Matthias On 6/27/17 9:05 AM, Jorge Esteban Quilcate Otoya wrote: > Thanks for the feedback Matthias! > > The main idea is to use only 1 tool to reset offsets and don't replicate > functionality between tools. > Reset Offset (KIP-122) tool not only reset but support execute the reset > but also export, import from files, etc. > If we extend the current tool (kafka-streams-application-reset.sh) we will > have to duplicate all this functionality also. > Maybe another option is to move the current implementation into > `kafka-consumer-group` and add a new command `--reset-offset-streams` with > the current implementation functionality and add `--reset-offset` options > for input topics. Does this make sense? > > > El lun., 26 jun. 2017 a las 23:32, Matthias J. Sax (<matth...@confluent.io>) > escribió: > >> Jorge, >> >> thanks a lot for this KIP. Allowing the reset streams applications with >> arbitrary start offset is something we got multiple requests already. >> >> Couple of clarification question: >> >> - why do you want to deprecate the current tool instead of extending >> the current tool with the stuff the offset reset tool can do (ie, use >> the offset reset tool internally) >> >> - you suggest to extend the offset reset tool to replace the stream >> reset tool: how would the reset tool know if it is resetting a streams >> applications or a regular consumer group? >> >> >> >> -Matthias >> >> >> On 6/26/17 1:28 PM, Jorge Esteban Quilcate Otoya wrote: >>> Hi all, >>> >>> I'd like to start the discussion to add reset offset tooling for Stream >>> applications. >>> The KIP can be found here: >>> >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-171+-+Extend+Consumer+Group+Reset+Offset+for+Stream+Application >>> >>> Thanks, >>> Jorge. >>> >> >> >
signature.asc
Description: OpenPGP digital signature
