Thanks for the updated KIP Bill.

In the PR you have AbstractBatchingRestoreCallback and
AbstractNotifyingRestoreCallback which are both in public packages, so are
part of the API. I think you need to add those to the KIP to round it off.

Otherwise LGTM.

Thanks,
Damian

On Fri, 30 Jun 2017 at 12:39 Bill Bejeck <bbej...@gmail.com> wrote:

> Hi,
>
> I updated the KIP yesterday and reposted on the original thread, but I
> think it may get lost in the shuffle.  I'd like to have one more round of
> discussion on the KIP found here:
>
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-167%3A+Add+interface+for+the+state+store+restoration+process
>
> There's also an initial PR here :
> https://github.com/apache/kafka/pull/3325
>

Reply via email to