In the diff you gave, onInvalidTimestamp() doesn't have any check. What if the timestamp corresponds to 5000 BC ? Is that still allowed ?
Cheers On Tue, Dec 5, 2017 at 10:29 AM, Konstantin Chukhlomin <chuhlo...@gmail.com> wrote: > Hi Ted, > > Thank you for the response. > I made a relevant changes to the KIP. > > > On Dec 5, 2017, at 11:59 AM, Ted Yu <yuzhih...@gmail.com> wrote: > > > > In KeepTimestampOnInvalidTimestamp, there should be check that > timestamp is > > < 0. > > This would protect against future change to onInvalidTimestamp() > callback. > > Not quite follow here, could you tell more? > > > Wednesday, December 31, 1969 11:59:59 PM UTC was in the past. Can you > > enrich Motivation section on why the proposal is made (writing data > > generated nowadays wouldn't result in negative timestamp)? > > > > In Compatibility section, there are two questions without answers. > > Are you going to fill out later ? > > > > Cheers > > > > On Tue, Dec 5, 2017 at 8:40 AM, Konstantin Chukhlomin < > chuhlo...@gmail.com> > > wrote: > > > >> Hi all, > >> > >> I have created a KIP to support negative timestamp: > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP- > >> 228+Negative+record+timestamp+support <https://cwiki.apache.org/ > >> confluence/display/KAFKA/KIP-228+Negative+record+timestamp+support> > >> > >> Here are proposed changes: https://github.com/apache/ > >> kafka/compare/trunk...chuhlomin:trunk <https://github.com/apache/ > >> kafka/compare/trunk...chuhlomin:trunk> > >> > >> I'm pretty sure that not cases are covered, so comments and suggestions > >> are welcome. > >> > >> Thank you, > >> Konstantin > >
