Thanks, Ted. I've added the JIRA and mailing list links to the KIP, and I added Javadoc addressing your questions -- both in the KIP code blocks and on GitHub ( https://github.com/rondagostino/kafka/commit/c61f5bafad810b620ff1ebd04e1231d245183e36 ).
Ron On Wed, Feb 14, 2018 at 7:19 PM, Ted Yu <yuzhih...@gmail.com> wrote: > Nicely written KIP. > > Can you add link to this thread and fill in JIRA number ? > > For ExpiringCredential, why does expireTimeMillis() return long while other > methods return Long ? > Can you add some comment for WindowJitter in RefreshConfig ? > > Thanks > > On Wed, Feb 14, 2018 at 3:38 PM, Ron Dagostino <rndg...@gmail.com> wrote: > > > Hi everyone. > > > > I created KIP-255: OAuth Authentication via SASL/OAUTHBEARER > > <https://cwiki.apache.org/confluence/pages/viewpage. > action?pageId=75968876 > > > > > (https://cwiki.apache.org/confluence/pages/viewpage. > > action?pageId=75968876 > > ). > > > > This KIP proposes adding the ability to authenticate to Kafka with OAuth > 2 > > bearer tokens using the OAUTHBEARER SASL mechanism. > > > > The code blocks in the KIP all reflect the implementation at > > https://github.com/rondagostino/kafka/tree/KAFKA-4292_plus_oauthbearer. > > Feel free to look there for more details if the code blocks whet your > > appetite for more. Everything described in the KIP as currently worded > is > > implemented there (77% code coverage with tests) except for the ability > to > > perform substitution in JAAS config module options. > > > > Ron > > >