bq. "--config-file" in ConfigCommand. Please update the above - it should be StreamsResetter
On Wed, Jul 11, 2018 at 7:59 PM Dong Lin <[email protected]> wrote: > Hey Ted, > > Thanks much for the suggestion. Yeah "config-file" looks better than > "command-config". I have updated the KIP as suggested. > > Thanks, > Dong > > On Wed, Jul 11, 2018 at 5:57 PM, Ted Yu <[email protected]> wrote: > > > Looking at StreamsResetter.java : > > > > commandConfigOption = optionParser.accepts("config-file", > "Property > > file containing configs to be passed to admin cl > > > > Not sure you have considered naming the option in the above fashion. > > > > Probably add the above to Alternative section. > > > > Cheers > > > > On Wed, Jul 11, 2018 at 2:04 PM Dong Lin <[email protected]> wrote: > > > > > Hi all, > > > > > > I have created KIP-340: Allow kafka-reassign-partitions.sh and > > > kafka-log-dirs.sh to take admin client property file. See > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > 340%3A+Allow+kafka-reassign-partitions.sh+and+kafka-log- > > dirs.sh+to+take+admin+client+property+file > > > . > > > > > > This KIP provides a way to allow kafka-reassign-partitions.sh and > > > kafka-log-dirs.sh to talk to broker over SSL. Please review the KIP if > > you > > > have time. > > > > > > > > > Thanks! > > > Dong > > > > > >
