Hi Rajini, Yes, I too prefer using "--command-config" . Recently in one of the other KIPs (KIP-340), it was suggested to use "--config-file", So I just followed the recent suggestion. But I think we should use same name in all tools (at least in core tools).
If there are no concerns, I will change the option to "--command-config". Since KIP-340 PR is not yet merged, we can also change there. Thanks, On Fri, Aug 3, 2018 at 1:57 PM Rajini Sivaram <rajinisiva...@gmail.com> wrote: > Hi Manikumar, > > We have some tools already (ConfigCommand, ConsumerGroupCommand, > DelegationTokenCommand) which use "--command-config" option to specify > config file. Perhaps use should use the same name for AclCommand as well? > > On Thu, Aug 2, 2018 at 7:23 PM, Colin McCabe <cmcc...@apache.org> wrote: > > > +1 for starting the vote > > > > cheers, > > Colin > > > > > > On Wed, Aug 1, 2018, at 08:46, Manikumar wrote: > > > Hi all, > > > > > > If there are no concerns, I will start the voting process soon. > > > > > > Thanks > > > > > > On Tue, Jul 31, 2018 at 9:08 AM Manikumar <manikumar.re...@gmail.com> > > wrote: > > > > > > > Hi Colin, > > > > > > > > Yes, "--authorizer-properties" option is not required with > > > > "--bootstrap-server" option. Updated the KIP. > > > > > > > > > > > > Thanks, > > > > > > > > On Tue, Jul 31, 2018 at 1:30 AM Ted Yu <yuzhih...@gmail.com> wrote: > > > > > > > >> Look good to me. > > > >> > > > >> On Mon, Jul 23, 2018 at 7:30 AM Manikumar < > manikumar.re...@gmail.com> > > > >> wrote: > > > >> > > > >> > Hi all, > > > >> > > > > >> > I have created a KIP to use AdminClient API in AclCommand > > > >> (kafka-acls.sh) > > > >> > > > > >> > * > > > >> > > > > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > 332%3A+Update+AclCommand+to+use+AdminClient+API* > > > >> > < > > > >> > > > > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > 332%3A+Update+AclCommand+to+use+AdminClient+API > > > >> > > > > > >> > > > > >> > Please take a look. > > > >> > > > > >> > Thanks, > > > >> > > > > >> > > > > > > >
