Hi Dong, I don't have a preference for the option itself, but we are using " --command-config" in ConfigCommand, ConsumerGroupCommand, BrokerApiVersionsCommand, DeleteRecordsCommand. So it feels like we should use the same here. I think we are currently only using "--config-file" StreamsResetter. I will let others comment on whether we should change to this when we add the option to other tools.
Regards, Rajini On Fri, Aug 3, 2018 at 5:41 PM, Dong Lin <lindon...@gmail.com> wrote: > Hey Rajini, Manikumar, > > Currently kafka-streams-application-reset.sh uses "--config-file" and a > few > other tools uses "--command-config". So the config name will be > inconsistent no matter which config name we choose. Not sure we currently > distinquish between core commands and non-core commands. I am wondering if > it is better to choose the name that is better in the long term. Do you > think `config-file` would be more intuitive than `command-config` here? > > Thanks, > Dong > > On Fri, Aug 3, 2018 at 2:40 AM, Manikumar <manikumar.re...@gmail.com> > wrote: > > > Updated the KIP. added a note to KIP-340 discussion thread. > > > > On Fri, Aug 3, 2018 at 2:52 PM Rajini Sivaram <rajinisiva...@gmail.com> > > wrote: > > > > > Thanks Manikumar. Can you add a note to the KIP-340 discussion thread? > > > > > > On Fri, Aug 3, 2018 at 10:04 AM, Manikumar <manikumar.re...@gmail.com> > > > wrote: > > > > > > > Hi Rajini, > > > > > > > > Yes, I too prefer using "--command-config" . Recently in one of the > > > other > > > > KIPs (KIP-340), it was suggested to use > > > > "--config-file", So I just followed the recent suggestion. But I > think > > we > > > > should use same name in all tools (at least in core tools). > > > > > > > > If there are no concerns, I will change the option to > > > "--command-config". > > > > Since KIP-340 PR is not yet merged, we can also change there. > > > > > > > > Thanks, > > > > > > > > > > > > On Fri, Aug 3, 2018 at 1:57 PM Rajini Sivaram < > rajinisiva...@gmail.com > > > > > > > wrote: > > > > > > > > > Hi Manikumar, > > > > > > > > > > We have some tools already (ConfigCommand, ConsumerGroupCommand, > > > > > DelegationTokenCommand) which use "--command-config" option to > > specify > > > > > config file. Perhaps use should use the same name for AclCommand as > > > well? > > > > > > > > > > On Thu, Aug 2, 2018 at 7:23 PM, Colin McCabe <cmcc...@apache.org> > > > wrote: > > > > > > > > > > > +1 for starting the vote > > > > > > > > > > > > cheers, > > > > > > Colin > > > > > > > > > > > > > > > > > > On Wed, Aug 1, 2018, at 08:46, Manikumar wrote: > > > > > > > Hi all, > > > > > > > > > > > > > > If there are no concerns, I will start the voting process soon. > > > > > > > > > > > > > > Thanks > > > > > > > > > > > > > > On Tue, Jul 31, 2018 at 9:08 AM Manikumar < > > > manikumar.re...@gmail.com > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > Hi Colin, > > > > > > > > > > > > > > > > Yes, "--authorizer-properties" option is not required with > > > > > > > > "--bootstrap-server" option. Updated the KIP. > > > > > > > > > > > > > > > > > > > > > > > > Thanks, > > > > > > > > > > > > > > > > On Tue, Jul 31, 2018 at 1:30 AM Ted Yu <yuzhih...@gmail.com> > > > > wrote: > > > > > > > > > > > > > > > >> Look good to me. > > > > > > > >> > > > > > > > >> On Mon, Jul 23, 2018 at 7:30 AM Manikumar < > > > > > manikumar.re...@gmail.com> > > > > > > > >> wrote: > > > > > > > >> > > > > > > > >> > Hi all, > > > > > > > >> > > > > > > > > >> > I have created a KIP to use AdminClient API in AclCommand > > > > > > > >> (kafka-acls.sh) > > > > > > > >> > > > > > > > > >> > * > > > > > > > >> > > > > > > > > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > > > > > 332%3A+Update+AclCommand+to+use+AdminClient+API* > > > > > > > >> > < > > > > > > > >> > > > > > > > > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > > > > > 332%3A+Update+AclCommand+to+use+AdminClient+API > > > > > > > >> > > > > > > > > > >> > > > > > > > > >> > Please take a look. > > > > > > > >> > > > > > > > > >> > Thanks, > > > > > > > >> > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
