Hi Guillaume,

If we agree that we have a single distribution (which I don't like as a pure Unix people ;)), I have no problem to rename it.

We just have to update dependant scripts (in admin, start, stop, etc).

Regards
JB

On 11/30/2011 08:20 AM, Guillaume Nodet wrote:
Originally, the distribution did not contain both unix and windows
files (there are 2 different distributions in 2.x), but given we now
have a single distribution containing both files, it seems to me a bit
more homogeneous to have ".bat" for windows batches and ".sh" for unix
scripts.
So I'm *slightly* inclined to rename those, but that's not really a
big problem to me.  If it can help some users, why not ....

Jean-Baptiste, do you see any problem with renaming those files apart
from the fact that it's not really necessary on unix (so I do agree
that it's not a requirement).

On Wed, Nov 30, 2011 at 05:25, Jean-Baptiste Onofré<[email protected]>  wrote:
Hi Andres,

My comments:

1/ the windows script as .bat extension because it's a requirement on
Windows
2/ the important thing is the header (#!/bin/sh) in the unix script more
than the extension.
3/ it's really important, for portability, to use /bin/sh (which allow us to
use with bash, zsh on Linux, csh and ksh on Solaris/AIX) more than /bin/bash

I don't see a good reason to rename to karaf.sh, karaf looks very good for
me.

Regards
JB

On 11/30/2011 05:21 AM, Andreas Pieber wrote:

Hey guys,

I want to start a discussion about this JIRA here on the dev list: TBH I'm
personally quite indifferent but if we want to change this we should do it
now for 3.0 or otherwise it wont happen for quite a long time (till 4.0).

So, WDYT?

Kind regards,
Andreas

---------- Forwarded message ----------
From: Andrei Pozolotin (Created) (JIRA)<[email protected]>
Date: Tue, Nov 29, 2011 at 23:45
Subject: [jira] [Created] (KARAF-1060) use bash file extenstions: karaf ->
karaf.sh
To: [email protected]


use bash file extenstions: karaf ->    karaf.sh
--------------------------------------------

                 Key: KARAF-1060
                 URL: https://issues.apache.org/jira/browse/KARAF-1060
             Project: Karaf
          Issue Type: Bug
            Reporter: Andrei Pozolotin


currently, windows /bin files have extensions, such as
karaf.bat

but unix, do not:
karaf

I suggest to use, instead:
karaf.sh

so that I can associate *.sh with bash editors like this
http://sourceforge.net/projects/shelled/

:-)


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA
administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


--
Jean-Baptiste Onofré
[email protected]
http://blog.nanthrax.net
Talend - http://www.talend.com





--
Jean-Baptiste Onofré
[email protected]
http://blog.nanthrax.net
Talend - http://www.talend.com

Reply via email to