Not a big deal, but I agree that ".sh" doesn't look as nice, and have
the additional concern that using karaf.sh might give the impression
that the Karaf team doesn't realize that the ".sh" is unneeded in order
to run *nix shell scripts. And when you give the impression to users
that you are uneducated on a rather simple matter, they might worry
where else within Karaf that lack of education will surface. :)
Andrei's use case, so he can click on the Karaf file directly using a
third-party Eclipse plugin instead of right-clicking on the file and
choosing "Open With-->{third-party Eclipse plugin}" is not significant
enough IMO to merit this change. (If the 3rd party plugin does not
offer that right-click option, the bug report should go to the plugin,
not Karaf.) If he is really editing the file that often, he can rename
it with that extension locally on his machine, the "karaf" script gets
renamed all the time through branding.
Glen
On 11/29/2011 11:25 PM, Jean-Baptiste Onofré wrote:
Hi Andres,
My comments:
1/ the windows script as .bat extension because it's a requirement on
Windows
2/ the important thing is the header (#!/bin/sh) in the unix script
more than the extension.
3/ it's really important, for portability, to use /bin/sh (which allow
us to use with bash, zsh on Linux, csh and ksh on Solaris/AIX) more
than /bin/bash
I don't see a good reason to rename to karaf.sh, karaf looks very good
for me.
Regards
JB
On 11/30/2011 05:21 AM, Andreas Pieber wrote:
Hey guys,
I want to start a discussion about this JIRA here on the dev list:
TBH I'm
personally quite indifferent but if we want to change this we should
do it
now for 3.0 or otherwise it wont happen for quite a long time (till
4.0).
So, WDYT?
Kind regards,
Andreas
---------- Forwarded message ----------
From: Andrei Pozolotin (Created) (JIRA)<[email protected]>
Date: Tue, Nov 29, 2011 at 23:45
Subject: [jira] [Created] (KARAF-1060) use bash file extenstions:
karaf ->
karaf.sh
To: [email protected]
use bash file extenstions: karaf -> karaf.sh
--------------------------------------------
Key: KARAF-1060
URL: https://issues.apache.org/jira/browse/KARAF-1060
Project: Karaf
Issue Type: Bug
Reporter: Andrei Pozolotin
currently, windows /bin files have extensions, such as
karaf.bat
but unix, do not:
karaf
I suggest to use, instead:
karaf.sh
so that I can associate *.sh with bash editors like this
http://sourceforge.net/projects/shelled/
:-)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA
administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see:
http://www.atlassian.com/software/jira
--
Glen Mazza
Talend Community Coders
http://coders.talend.com
blog: http://www.jroller.com/gmazza
