Hi, +1 Regarding kogito_data_cache, the renaming is tricky, because actually name is the name of the cache and key is the name of the variable stored in the cache, so I would use
name->cacheName key->varName On Mon, Dec 9, 2024 at 6:31 PM Deepak Joseph <[email protected]> wrote: > Hello Everyone, > > Few of the data-index tables uses reserved keywords as column names (e.g. > key, value). In most of the cases DBs supports them without any problem but > at least H2 has problems with this at this moment. > > The solution we currently use is to establish the JDBC connection with the > `NO_KEYWORDS=key,value` argument to bypass the SQL reserved words. There is > workaround in this case, but it is not a proper solution as we are going to > need to revisit this at some point. > > We are thinking to rename these column names to something more safe and > appropriate striving for a more proper naming convention. > > Related PR: https://github.com/apache/incubator-kie-kogito-apps/pull/2139 > > As suggested in the PR comments, maybe we can change > key -> name (definitions_nodes_metadata, > definitions_metadata) > value -> stringValue (definitions_nodes_metadata, > definitions_metadata) > value -> annotation (definitions_annotations) > key -> cache_key (kogito_data_cache) > > Please feel free to share any other ideas or suggestions that might help > in addressing this. I’m happy to explore different approaches. > > > Thanks, > Deepak Joseph >
