Hi,
Since this is a discussion, I would like to discuss the renaming details
(not the fact that renaming them in the long run makes sense).
My proposal is
key -> name (definitions_nodes_metadata,
definitions_metadata)
value -> meta_value (definitions_nodes_metadata,
definitions_metadata)
value -> annotation (definitions_annotations)
name -> cache_name (kogito_data_cache)
key -> var_name (kogito_data_cache)
On Tue, Dec 10, 2024 at 9:27 AM Pere Fernandez <[email protected]> wrote:
> Hi Deepak, thank you for rising this topic!
>
> I'm +1 for this change, I think that this change can save us from having
> problems in the long run.
>
> Cheers!
>
> On 2024/12/09 17:31:02 Deepak Joseph wrote:
> > Hello Everyone,
> >
> > Few of the data-index tables uses reserved keywords as column names
> (e.g. key, value). In most of the cases DBs supports them without any
> problem but at least H2 has problems with this at this moment.
> >
> > The solution we currently use is to establish the JDBC connection with
> the `NO_KEYWORDS=key,value` argument to bypass the SQL reserved words.
> There is workaround in this case, but it is not a proper solution as we are
> going to need to revisit this at some point.
> >
> > We are thinking to rename these column names to something more safe and
> appropriate striving for a more proper naming convention.
> >
> > Related PR:
> https://github.com/apache/incubator-kie-kogito-apps/pull/2139
> >
> > As suggested in the PR comments, maybe we can change
> > key -> name (definitions_nodes_metadata,
> definitions_metadata)
> > value -> stringValue (definitions_nodes_metadata,
> definitions_metadata)
> > value -> annotation (definitions_annotations)
> > key -> cache_key (kogito_data_cache)
> >
> > Please feel free to share any other ideas or suggestions that might help
> in addressing this. I’m happy to explore different approaches.
> >
> >
> > Thanks,
> > Deepak Joseph
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
>
>
