[
https://issues.apache.org/jira/browse/KNOX-402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14063568#comment-14063568
]
Larry McCay commented on KNOX-402:
----------------------------------
Hi [~zacblanco] - a couple things - right off the bat:
1. TopologyService is empty - it must not have been staged when you made the
patch - it is also missing the apache license
2. we need to decide on whether to use services.deployment or services.topology
packages the test is in topology - I think that I would prefer topology
3. remove the statics from methods in DefaultTopologyService
4. I noticed that you changed whitespaces before and after parens - I don't use
those extra spaces either but be aware that reformatting existing code is
usually not expected. If intellij did it automatically then you may want to
turn that off.
Thanks again!
> New GatewayService - TopologyService
> ------------------------------------
>
> Key: KNOX-402
> URL: https://issues.apache.org/jira/browse/KNOX-402
> Project: Apache Knox
> Issue Type: Improvement
> Components: Build, Server
> Affects Versions: 0.5.0
> Reporter: Zachary Blanco
> Priority: Minor
> Labels: patch
> Fix For: 0.5.0
>
> Attachments: KNOX-402.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> FileTopologyProvider inside of GatewayServer was replaced to use the new
> TopologyService that acts to detect changes under /conf/topologies
--
This message was sent by Atlassian JIRA
(v6.2#6252)
