[
https://issues.apache.org/jira/browse/KNOX-402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14065425#comment-14065425
]
Kevin Minder commented on KNOX-402:
-----------------------------------
Feedback on KNOX-402.patch from 7/16/2014 18:00
# DefaultTopologyServiceTest - I think the imports for TopologyService and
DefaultTopologyService are wrong.
# GatewayServer - redeployTopolgoies still has a parameter config that isn't
used. How does this affect the three usages of this method?
# KnoxCLI - RedeployCommand.execute creates a GatewayConfig instance that isn't
used.
# TopologyService - The import of GatewayConfig is unnecessary
> New GatewayService - TopologyService
> ------------------------------------
>
> Key: KNOX-402
> URL: https://issues.apache.org/jira/browse/KNOX-402
> Project: Apache Knox
> Issue Type: Improvement
> Components: Build, Server
> Affects Versions: 0.5.0
> Reporter: Zachary Blanco
> Priority: Minor
> Labels: patch
> Fix For: 0.5.0
>
> Attachments: KNOX-402.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> FileTopologyProvider inside of GatewayServer was replaced to use the new
> TopologyService that acts to detect changes under /conf/topologies
--
This message was sent by Atlassian JIRA
(v6.2#6252)
