[
https://issues.apache.org/jira/browse/KNOX-565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632611#comment-14632611
]
Kevin Minder commented on KNOX-565:
-----------------------------------
@Yu Gao < Excellent. Seems you have used all of the pieces exactly the way I
had intended them to be used. I've no idea who you figured them out without
even asking any questions. My feedback would be minor.
# I'm not in love with the name of UrlRewriteReaderBase given what it contains
but I think I understand the compromise you made.
# I'd prefer to have more of the classes directly unit tested. However it
looks like the ones that are not directly tested are indirectly tested.
# Ideally there would be some coverage in GatewayBasicFuncTest for pseudo
system level testing. That can be a bit of a beast and we can tackle that as a
second patch.
# The tests don't seem to pass with the patch applied. Use {{ant verify}} or
the near equivalent {{mvn -Prelease clean install}}
Beyond that I'd like to get a build of this running against a cluster and do
some testing but once there is a version of the patch that passes the test I'm
inclined to commit.
One thing we do need to consider is how this may mix with any uptake of
X-Forwarded-Context moving forward. For background, the use of
X-Forwarded-Context goes beyond the typical X-Forwarded-* headers to include a
context path under which a proxies service should "pre-rewrite" their URLs.
This only matters because we should make sure that the routes and rewrite rules
in this patch define URLs that the UIs generate given an appropriate
X-Forwarded-Context hint.
> Supporting All the Quick Links on Ambari Dashboard to Go Through Knox
> ---------------------------------------------------------------------
>
> Key: KNOX-565
> URL: https://issues.apache.org/jira/browse/KNOX-565
> Project: Apache Knox
> Issue Type: New Feature
> Components: Server
> Affects Versions: 0.7.0
> Reporter: Tanping Wang
> Fix For: 0.7.0
>
> Attachments: KNOX-565 - UI support design.pdf, KNOX-565-001.patch
>
>
> Today Knox supports authentication and service level authorization for rest
> APIs. We have a need to have all of the user interfaces to also go through
> Knox. So that Knox can become the single hub for all https communications
> including both UIs and rest calls.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
