[
https://issues.apache.org/jira/browse/KNOX-528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15749489#comment-15749489
]
Sandeep More commented on KNOX-528:
-----------------------------------
I ran a quick test on the patch and was able to get it work with just service
definitions in sandbox.xml, I also ran it with HA configuration and works
great, thanks [~mcparlandjcgi] good stuff !
*Some comments on the patch:*
1. The Unit Test failed for me, this was just because Knox shuffled the query
arguments around
{code:java}
java.lang.AssertionError:
Expected: is
"http://sandbox.hortonworks.com/solr/KnoxSolrIntegration/select?q=*.*&indent=true&wt=json";
but: was
"http://sandbox.hortonworks.com/solr/KnoxSolrIntegration/select?indent=true&q=*.*&wt=json";
{code}
Maybe break down the 'outputUri' into host/path/query and check - there might
be other better ways to do this.
2. Parser.parse( ) is deprecated so might be good to use Parser.parseTemplate()
instead so that the test is not broken when the Parser.parse( ) api goes away.
3. Solr latest release is 6.3.0 any reason why the version is 5.5.0. I know it
does not matter as long as the api remains same, but it might give an
impressions that the api is not tested (which, I did and works great !) and
updated for 6.3.0.
Again, thanks !
> Support for Apache SOLR REST APIs
> ---------------------------------
>
> Key: KNOX-528
> URL: https://issues.apache.org/jira/browse/KNOX-528
> Project: Apache Knox
> Issue Type: Improvement
> Reporter: Rick Kellogg
> Assignee: John McParland
> Fix For: 0.11.0
>
> Attachments: KNOX-528.patch, KNOX-528_basicauth_squashed.patch,
> KNOX-528_squashed.patch, knoxSolrTestEvidence.txt, solrTestEvidence.txt
>
>
> Add Knox support for routing and securing Apache SOLR's REST APIs
> See: https://wiki.apache.org/solr/Solrj
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
