[
https://issues.apache.org/jira/browse/KNOX-931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16003986#comment-16003986
]
Larry McCay commented on KNOX-931:
----------------------------------
Hi [~Wancy] - I have taken a quick look at this change and am a little
skeptical of requiring the use of an instanceof.
This is often a sign of some OO design flaw.
The programming model of request wrapping with servlet filters may actually
require this but I need to look more closely.
Can you please provide a patch rather than a pull request as well?
I will look more closely at the intent and whether we can avoid the instanceof
here tomorrow.
Thanks for your contribution!
> asType will not work for body filter when using IdentityAsserterFilter
> ----------------------------------------------------------------------
>
> Key: KNOX-931
> URL: https://issues.apache.org/jira/browse/KNOX-931
> Project: Apache Knox
> Issue Type: Bug
> Affects Versions: 0.11.0
> Reporter: Shi Wang
> Assignee: Shi Wang
> Fix For: 0.13.0
>
>
> In IdentityAsserterHttpServletsWrapper.java, method getInputStream(),
> The body will always be urlEncoded if the contentType is
> "application/x-www-form-urlencoded"
> And self defined filter that change "application/x-www-form-urlencoded" as
> other contentType for requestbody will be invalid.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
