[ 
https://issues.apache.org/jira/browse/KNOX-931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16022176#comment-16022176
 ] 

Shi Wang commented on KNOX-931:
-------------------------------

Hi [[email protected]]
Your interpret of the use case is totally correct and that's a good question :) 
I actually found this issue because someone didnt add -H "Content-Type: 
application/json" in the curl command and then found asType could "magically" 
solve this without specifying -H "Content-Type: application/json" but without 
asserterFilter. And then I did some search found in KNOX-18 Kevin mentioned 
about the request body manipulate. So I thought it could be necessary to find a 
solution about this. 

And I understand your concern now. I think it will take more time and more 
tests to do it appropriately and comprehensively.  Since it is not a common use 
case maybe we can lower the priority and give it more time for future releases? 


> asType will not work for body filter when using IdentityAsserterFilter
> ----------------------------------------------------------------------
>
>                 Key: KNOX-931
>                 URL: https://issues.apache.org/jira/browse/KNOX-931
>             Project: Apache Knox
>          Issue Type: Bug
>    Affects Versions: 0.11.0
>            Reporter: Shi Wang
>            Assignee: Shi Wang
>             Fix For: 0.13.0
>
>         Attachments: 
> 0001-KNOX-931-asType-will-not-work-for-body-filter-when-u.patch
>
>
> In IdentityAsserterHttpServletsWrapper.java, method getInputStream(),
> The body will always be urlEncoded if the contentType is 
> "application/x-www-form-urlencoded"
> And self defined filter that change "application/x-www-form-urlencoded" as 
> other contentType for requestbody will be invalid.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to