[ 
https://issues.apache.org/jira/browse/KNOX-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16220598#comment-16220598
 ] 

Sandeep More commented on KNOX-1039:
------------------------------------

Thanks for the updated patch [~pzampino]

The patch looks great, just one thing stuck out in the file 
TopologyResource.java, there are multiple places where we throw 
e.printstacktrace() when error occurs. We should probably convert them to 
log.error() and return a appropriate failure response (5XX server error)

> Add Support For Simple Descriptors and Policy Config to Knox Admin API
> ----------------------------------------------------------------------
>
>                 Key: KNOX-1039
>                 URL: https://issues.apache.org/jira/browse/KNOX-1039
>             Project: Apache Knox
>          Issue Type: Sub-task
>          Components: Server
>            Reporter: Phil Zampino
>            Assignee: Phil Zampino
>              Labels: kip-8
>             Fix For: 0.14.0
>
>         Attachments: KNOX-1039-001.patch, KNOX-1039-002.patch, 
> KNOX-1039.patch, sandbox-providers.xml, sandbox.json
>
>
> The Knox admin API needs to support CRUD operations for simple descriptors 
> and externalized provider configurations.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to