awesome ! On Tue, Jan 30, 2018 at 2:28 PM, Phil Zampino <[email protected]> wrote:
> Actually, I'm going to quickly correct the CHANGES issue I mentioned before > we generate a new RC. > > On Tue, Jan 30, 2018 at 2:22 PM, Sandeep More <[email protected]> > wrote: > > > The issue should be fixed and in 1.0.0 and master. > > We should be good to go (again .. ) > > > > Best, > > Sandeep > > > > On Tue, Jan 30, 2018 at 12:10 PM, larry mccay <[email protected]> > > wrote: > > > > > Good catch, Sandeep! > > > > > > This is a blocker, IMO - here is my: > > > > > > -1 > > > > > > Let's get the fix in and I will spin a new RC. > > > > > > On Tue, Jan 30, 2018 at 10:02 AM, Phil Zampino <[email protected]> > > > wrote: > > > > > > > Glad you found it now. > > > > > > > > On Tue, Jan 30, 2018 at 9:29 AM, Sandeep More <[email protected] > > > > > > wrote: > > > > > > > > > While doing some testing on Pac4J provider found out a bug that > > causes > > > > > classnotfound exception, this is a side effect of Package > > > Restructuring > > > > :( > > > > > I will open up a bug and try to get it fixed ASAP. > > > > > > > > > > Best, > > > > > Sandeep > > > > > > > > > > On Fri, Jan 26, 2018 at 11:05 AM, Sandeep More < > > [email protected]> > > > > > wrote: > > > > > > > > > > > The addition of shims is done and they seem to work as expected > > with > > > > some > > > > > > testing I did on them. > > > > > > We should be good to go with 1.0.0 ! > > > > > > > > > > > > Sorry for holding up the release :( > > > > > > > > > > > > Best, > > > > > > Sandeep > > > > > > > > > > > > On Tue, Jan 23, 2018 at 5:25 PM, Sandeep More < > > [email protected] > > > > > > > > > > wrote: > > > > > > > > > > > >> I just stumbled across an issue where ClassNotFoundException can > > be > > > > > >> thrown if the service defs are not upgraded (e.g. webhdfs > service > > > > > >> definition). > > > > > >> I created KNOX-1168 <https://issues.apache.org/ > > > jira/browse/KNOX-1168> > > > > > to > > > > > >> address the issue and it should probably go in 1.0.0 branch, > sorry > > > :( > > > > > >> > > > > > >> I see that 1.0.0 branch has already been created, I will get > this > > > > > >> committed to both 1.0.0 and 1.1.0 (master). > > > > > >> Let me know if you have any questions or concerns. > > > > > >> > > > > > >> Best, > > > > > >> Sandeep > > > > > >> > > > > > >> > > > > > >> On Tue, Jan 23, 2018 at 4:36 PM, Philip Zampino < > > [email protected] > > > > > > > > > >> wrote: > > > > > >> > > > > > >>> +1 > > > > > >>> > > > > > >>> > > > > > >>> > > > > > >>> Let's get 1.0.0 released, so we can continue with the > > improvements! > > > > > >>> > > > > > >>> > > > > > >>> > > > > > >>> > > > > > >>> On Tue, Jan 23, 2018 at 11:58 AM, Sandeep More < > > > > [email protected]> > > > > > >>> wrote: > > > > > >>> > > > > > >>> > +1 > > > > > >>> > Sounds good, once we get 1.0.0 out the door we can start > > letting > > > in > > > > > the > > > > > >>> > features and bugs. > > > > > >>> > > > > > > >>> > Best, > > > > > >>> > Sandeep > > > > > >>> > > > > > > >>> > > > > > > >>> > On Tue, Jan 23, 2018 at 2:38 PM, larry mccay < > > [email protected]> > > > > > >>> wrote: > > > > > >>> > > > > > > >>> > > All - > > > > > >>> > > > > > > > >>> > > Since we have descoped 1.0.0 down to just a couple doc > > issues, > > > I > > > > am > > > > > >>> > > thinking that it is time to branch for the 1.0.0 release. > > > > > >>> > > > > > > > >>> > > I will also try and spin the first rc as well. > > > > > >>> > > > > > > > >>> > > Thoughts, concerns? > > > > > >>> > > > > > > > >>> > > thanks, > > > > > >>> > > > > > > > >>> > > --larry > > > > > >>> > > > > > > > >>> > > > > > > >>> > > > > > >> > > > > > >> > > > > > > > > > > > > > > > > > > > > >
