Created https://issues.apache.org/jira/browse/KNOX-1284
Kevin Risden On Fri, Apr 27, 2018 at 10:10 PM, Kevin Risden <[email protected]> wrote: > Thanks everyone. I'll create a JIRA and start on getting a patch together > over the next week or so. > > "pmd + checkstyle plugins" > > Those are good ones as well. Thanks Colm. > > Kevin Risden > > On Thu, Apr 26, 2018 at 7:59 AM, Philip Zampino <[email protected]> > wrote: > >> +1 Sounds like a good improvement. >> >> On Thu, Apr 26, 2018 at 8:51 AM, larry mccay <[email protected]> wrote: >> >> > +1 from me, Kevin! >> > >> > >> > On Thu, Apr 26, 2018 at 4:57 AM, Colm O hEigeartaigh < >> [email protected]> >> > wrote: >> > >> > > +1 - it's always good to have static build tools. Other projects I >> work >> > on >> > > use the pmd + checkstyle plugins to enforce code cleanliness. >> > > >> > > Colm. >> > > >> > > On Thu, Apr 26, 2018 at 5:21 AM, Kevin Risden <[email protected]> >> > wrote: >> > > >> > > > I've been looking into static build tools for Apache Calcite and >> > others. >> > > It >> > > > turns out there is a lot of overlap. I took some time to see how >> this >> > > would >> > > > apply to Apache Knox. I'm sending this message to gauge Apache Knox >> > > > interest in this approach. >> > > > >> > > > Some of the tools include: >> > > > * spotbugs [1] (newer version of findbugs) >> > > > * errorprone [2] >> > > > * forbiddenapis [3] >> > > > >> > > > An example of what this looks like partially implemented is here >> [4]. >> > > > >> > > > If this looks interesting I can break this down into JIRAs and add >> them >> > > as >> > > > pieces. At first would enable in "warn" mode and then as fixes are >> made >> > > > fail the build on errors for each module. >> > > > >> > > > [1] https://spotbugs.github.io/ >> > > > [2] http://errorprone.info/ >> > > > [3] https://github.com/policeman-tools/forbidden-apis >> > > > [4] >> > > > https://github.com/risdenk/knox/commit/970c183b8c130e009d6ac >> e37688945 >> > > > 874d91b7ca >> > > > >> > > > Kevin Risden >> > > > >> > > >> > > >> > > >> > > -- >> > > Colm O hEigeartaigh >> > > >> > > Talend Community Coder >> > > http://coders.talend.com >> > > >> > >> > >
