KNOX-1441 and KNOX-1442 are now in master. This will identify any problems with spotbugs or forbiddenapis.
As part of the review process for KNOX-1441 and KNOX-1442, it was identified that wildcard imports are not preferred. Colm had previously recommended checkstyle so I went ahead and created KNOX-1443 to add checkstyle. Details about what rules to enforce to start are in the JIRA. Kevin Risden On Fri, Sep 21, 2018 at 4:20 PM Kevin Risden <[email protected]> wrote: > Getting back to this after some time and not destabilizing the 1.0 and 1.1 > releases. > > I split KNOX-1284 into two JIRAs to address separately. > - KNOX-1441 [1] - Spotbugs > - KNOX-1442 [2] - Forbiddenapis > > The patches themselves are pretty large due to minor changes across the > code base from fixing the static checks (details in the JIRAs). KNOX-1442 > should apply on top of KNOX-1441. I tested against JDK 8 and there are no > issues in the tests. > > I'd prefer not to have to fix merge conflicts a lot if it can be avoided > by not waiting too long. Would appreciate a review though :) > > 1. https://issues.apache.org/jira/browse/KNOX-1441 > 2. https://issues.apache.org/jira/browse/KNOX-1442 > > Kevin Risden > > > On Sun, Apr 29, 2018 at 4:32 PM Kevin Risden <[email protected]> wrote: > >> Created https://issues.apache.org/jira/browse/KNOX-1284 >> >> Kevin Risden >> >> On Fri, Apr 27, 2018 at 10:10 PM, Kevin Risden <[email protected]> >> wrote: >> >>> Thanks everyone. I'll create a JIRA and start on getting a patch >>> together over the next week or so. >>> >>> "pmd + checkstyle plugins" >>> >>> Those are good ones as well. Thanks Colm. >>> >>> Kevin Risden >>> >>> On Thu, Apr 26, 2018 at 7:59 AM, Philip Zampino <[email protected]> >>> wrote: >>> >>>> +1 Sounds like a good improvement. >>>> >>>> On Thu, Apr 26, 2018 at 8:51 AM, larry mccay <[email protected]> wrote: >>>> >>>> > +1 from me, Kevin! >>>> > >>>> > >>>> > On Thu, Apr 26, 2018 at 4:57 AM, Colm O hEigeartaigh < >>>> [email protected]> >>>> > wrote: >>>> > >>>> > > +1 - it's always good to have static build tools. Other projects I >>>> work >>>> > on >>>> > > use the pmd + checkstyle plugins to enforce code cleanliness. >>>> > > >>>> > > Colm. >>>> > > >>>> > > On Thu, Apr 26, 2018 at 5:21 AM, Kevin Risden <[email protected]> >>>> > wrote: >>>> > > >>>> > > > I've been looking into static build tools for Apache Calcite and >>>> > others. >>>> > > It >>>> > > > turns out there is a lot of overlap. I took some time to see how >>>> this >>>> > > would >>>> > > > apply to Apache Knox. I'm sending this message to gauge Apache >>>> Knox >>>> > > > interest in this approach. >>>> > > > >>>> > > > Some of the tools include: >>>> > > > * spotbugs [1] (newer version of findbugs) >>>> > > > * errorprone [2] >>>> > > > * forbiddenapis [3] >>>> > > > >>>> > > > An example of what this looks like partially implemented is here >>>> [4]. >>>> > > > >>>> > > > If this looks interesting I can break this down into JIRAs and >>>> add them >>>> > > as >>>> > > > pieces. At first would enable in "warn" mode and then as fixes >>>> are made >>>> > > > fail the build on errors for each module. >>>> > > > >>>> > > > [1] https://spotbugs.github.io/ >>>> > > > [2] http://errorprone.info/ >>>> > > > [3] https://github.com/policeman-tools/forbidden-apis >>>> > > > [4] >>>> > > > >>>> https://github.com/risdenk/knox/commit/970c183b8c130e009d6ace37688945 >>>> > > > 874d91b7ca >>>> > > > >>>> > > > Kevin Risden >>>> > > > >>>> > > >>>> > > >>>> > > >>>> > > -- >>>> > > Colm O hEigeartaigh >>>> > > >>>> > > Talend Community Coder >>>> > > http://coders.talend.com >>>> > > >>>> > >>>> >>> >>> >>
