I second Phil. Personally, I am more comfortable with the patches mostly because of their simplistic nature but do like PRs as they are more community friendly (helps people review, comment, critique) and looks like they have become OSS standard as Phil pointed out. So +1 from me.
Best, Sandeep On Thu, Feb 7, 2019 at 4:06 PM Phil Zampino <[email protected]> wrote: > I like the PR model, and it is familiar to many who contribute to OSS > projects. I suppose we could continue to support the patch attached to a > Jira model, but we should encourage the PR model, IMHO. > > On Thu, Feb 7, 2019 at 4:03 PM larry mccay <[email protected]> wrote: > > > All - > > > > There has been interest from the Knox community in support of Pull > Requests > > from github. > > Our move to gitbox recently makes this easier to do. > > > > What are your thoughts on enabling PRs in general? > > Should we support both patches in JIRA as well as github based PRs? > > > > thanks, > > > > --larry > > >
