I think PRs are a good improvement since we get Travis CI checks by default
currently. Something that we currently don't get with patches
If we go this route we should make sure we have the following in place:
- PR Github Template with useful info
-
https://help.github.com/articles/creating-a-pull-request-template-for-your-repository/
- Livy has an example of this
- Ensure that PRs are automatically linked to JIRA
- Not currently done today and a pain since it should happen
automatically.
- Calcite has this. Might be a simple INFRA ticket
- Documentation for contributors/committers
- Committers - linked github/asf accounts, how to merge a PR
- Contributors what to expect/updated docs to move from patch -> PR
- Ensure that only squash/rebase/merge commits are allowed
- Lot of nuance here and Calcite recently had INFRA disable the
buttons for types that didn't fit their model
- Decided what to do with PR comments
- Some projects have PR comments go directly to JIRA comments.
- Others have them go to worklog in JIRA.
- Others don't capture PR comments in JIRA
So all in all in favor just need to make sure we have the plumbing in place.
Kevin Risden
On Thu, Feb 7, 2019 at 4:13 PM Sandeep Moré <[email protected]> wrote:
> I second Phil. Personally, I am more comfortable with the patches mostly
> because of their simplistic nature but do like PRs as they are more
> community friendly (helps people review, comment, critique) and looks like
> they have become OSS standard as Phil pointed out.
> So +1 from me.
>
> Best,
> Sandeep
>
> On Thu, Feb 7, 2019 at 4:06 PM Phil Zampino <[email protected]> wrote:
>
> > I like the PR model, and it is familiar to many who contribute to OSS
> > projects. I suppose we could continue to support the patch attached to a
> > Jira model, but we should encourage the PR model, IMHO.
> >
> > On Thu, Feb 7, 2019 at 4:03 PM larry mccay <[email protected]> wrote:
> >
> > > All -
> > >
> > > There has been interest from the Knox community in support of Pull
> > Requests
> > > from github.
> > > Our move to gitbox recently makes this easier to do.
> > >
> > > What are your thoughts on enabling PRs in general?
> > > Should we support both patches in JIRA as well as github based PRs?
> > >
> > > thanks,
> > >
> > > --larry
> > >
> >
>
