[
https://issues.apache.org/jira/browse/KNOX-1814?focusedWorklogId=210996&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-210996
]
ASF GitHub Bot logged work on KNOX-1814:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Mar/19 13:46
Start Date: 11/Mar/19 13:46
Worklog Time Spent: 10m
Work Description: risdenk commented on pull request #68: KNOX-1814 -
Moving conf/data folder checking to Java layer from bash
URL: https://github.com/apache/knox/pull/68#discussion_r264238280
##########
File path:
gateway-server/src/main/java/org/apache/knox/gateway/GatewayServer.java
##########
@@ -269,10 +280,28 @@ private static void validateKerberosConfig(GatewayConfig
config) throws GatewayC
}
private static void checkIfFileExistsAndCanBeRead(File fileToBeChecked,
String propertyName, Set<String> errors) {
+ checkIfFileExistsAndCanBeRead(fileToBeChecked, propertyName, errors,
false);
+ }
+
+ private static void checkIfDirectoryExistsAndCanBeRead(File fileToBeChecked,
String propertyName, Set<String> errors) {
Review comment:
Since these are new methods can we pass in a `Path` instead of a `File`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 210996)
Time Spent: 40m (was: 0.5h)
> Move directory check to Java layer
> ----------------------------------
>
> Key: KNOX-1814
> URL: https://issues.apache.org/jira/browse/KNOX-1814
> Project: Apache Knox
> Issue Type: Improvement
> Components: Server
> Reporter: Sandor Molnar
> Assignee: Sandor Molnar
> Priority: Major
> Fix For: 1.3.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Currently, the following folder checks exist in {{gateway.sh}}:
> * {{conf}} directory exists and can be read?
> * {{data}}, {{log}}, {{pid}} directories exist and can be written?
> Only the {{conf}} and {{data}} folders are used by the Java code ({{log}} and
> {{pid}} only used in the bash script). Those directories are configurable
> using GATEWAY_HOME in the Java layer, therefore those checks should either be
> removed or fixed, so they take those variables into account.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
