moresandeep commented on a change in pull request #78: KNOX-1584 - YARN v2 UI - 
Application - History link fix
URL: https://github.com/apache/knox/pull/78#discussion_r267484234
 
 

 ##########
 File path: 
gateway-service-definitions/src/main/resources/services/yarnuiv2/3.0.0/rewrite.xml
 ##########
 @@ -170,5 +170,13 @@
       <apply path="Location" 
rule="YARNUIV2/yarnuiv2/outbound/headers/index/location"/>
     </content>
   </filter>
+   
+  <rule dir="IN" name="YARNUIV2/yarnuiv2/inbound/proxy" 
pattern="*://*:*/**/yarnuiv2/proxy/{**}?{**}">
+      <rewrite template="{$serviceUrl[YARNUIV2]}/proxy/{**}?{**}"/>
+   </rule>
+
+   <rule dir="OUT" name="YARNUIV2/yarnuiv2/outbound/proxy" 
pattern="*://*:*/proxy/{**}">
+      <rewrite 
template="{gateway.scheme}://{gateway.host}:{gateway.port}/gateway/default/sparkhistory/history/{**}?{**}"/>
 
 Review comment:
   Right, also the rule "YARNUIV2/yarnuiv2/outbound/proxy" does not seem to be 
references anywhere, how is this getting triggered ? you might also want to try 
a more specific pattern for this rule, currently it is  `*://*:*/proxy/{**}`  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to