moresandeep commented on a change in pull request #78: KNOX-1584 - YARN v2 UI -
Application - History link fix
URL: https://github.com/apache/knox/pull/78#discussion_r267774856
##########
File path:
gateway-service-definitions/src/main/resources/services/yarnuiv2/3.0.0/rewrite.xml
##########
@@ -171,12 +171,34 @@
</content>
</filter>
- <rule dir="IN" name="YARNUIV2/yarnuiv2/inbound/proxy"
pattern="*://*:*/**/yarnuiv2/proxy/{**}?{**}">
- <rewrite template="{$serviceUrl[YARNUIV2]}/proxy/{**}?{**}"/>
- </rule>
+ <filter name="YARNUIV2/yarnuiv2/outbound/headers/jobhistory/job">
+ <content type="application/x-http-headers">
+ <apply path="Location"
rule="YARNUIV2/yarnuiv2/outbound/headers/jobhistory/job/location"/>
+ </content>
+ </filter>
+
+ <rule dir="OUT" name="YARNUIV2/yarnuiv2/outbound/proxy"
pattern="*://*:*/proxy/{**}">
+ <rewrite template="{$frontend[url]}/yarnuiv2/proxy/{**}"/>
Review comment:
{$serviceUrl[YARNUIV2]} is the preferred way. You want to include the
specific URL that was supplied in the topology file, that way changing the URL
in topology will update URL's all the rules.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
