goelrajat commented on a change in pull request #143: KNOX-1997: Adding changes
to buffer messages from backend in onMessag…
URL: https://github.com/apache/knox/pull/143#discussion_r321758865
##########
File path:
gateway-server/src/main/java/org/apache/knox/gateway/websockets/ProxyWebSocketAdapter.java
##########
@@ -198,12 +232,29 @@ public void onError(Throwable cause) {
@Override
public void onMessageText(String message, Object session) {
+ LOG.logMessage("[From Backend <---]" + message);
+ remoteLock.lock();
final RemoteEndpoint remote = getRemote();
Review comment:
What I observed that remote was being created in other thread which was
executing onWebSocketConnect() while this current thread received a message.
This might be an limitation with Jetty itself, check:
https://github.com/signalapp/Signal-Desktop/issues/1840.
I checked jetty examples and even there the server is using locks before
accessing remote, as mentioned in the above link.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
