goelrajat commented on a change in pull request #143: KNOX-1997: Adding changes 
to buffer messages from backend in onMessag…
URL: https://github.com/apache/knox/pull/143#discussion_r322179649
 
 

 ##########
 File path: 
gateway-server/src/main/java/org/apache/knox/gateway/websockets/ProxyWebSocketAdapter.java
 ##########
 @@ -198,12 +232,29 @@ public void onError(Throwable cause) {
 
       @Override
       public void onMessageText(String message, Object session) {
+        LOG.logMessage("[From Backend <---]" + message);
+        remoteLock.lock();
         final RemoteEndpoint remote = getRemote();
 
 Review comment:
   I tried adding a fixed delay of few seconds in onMessageText() API but I was 
still seeing the issue in some cases. So adding a fixed configurable delay will 
not work. I aslo want to avoid locks as they incur a performance overhead. IF 
you have any suggestions on how can locks be avoided, let me know. Thanks.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to