goelrajat commented on a change in pull request #143: KNOX-1997: Adding changes
to buffer messages from backend in onMessag…
URL: https://github.com/apache/knox/pull/143#discussion_r323246484
##########
File path:
gateway-server/src/main/java/org/apache/knox/gateway/websockets/GatewayWebsocketHandler.java
##########
@@ -117,7 +117,10 @@ public Object createWebSocket(ServletUpgradeRequest req,
final String backendURL = getMatchedBackendURL(path);
/* Upgrade happens here */
- return new ProxyWebSocketAdapter(URI.create(backendURL), pool,
getClientEndpointConfig(req));
+ ProxyWebSocketAdapter wsAdaptor = new ProxyWebSocketAdapter
+ (URI.create(backendURL), pool, getClientEndpointConfig(req));
+ wsAdaptor.setMaxBufferCount(config.getWebsocketMaxWaitBufferCount());
Review comment:
Yeah passing config as constructor argument makes more sense. Fixed now in
new commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
