[
https://issues.apache.org/jira/browse/KNOX-1996?focusedWorklogId=315573&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-315573
]
ASF GitHub Bot logged work on KNOX-1996:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Sep/19 10:23
Start Date: 20/Sep/19 10:23
Worklog Time Spent: 10m
Work Description: goelrajat commented on issue #142: KNOX-1996: Adding
changes to remove extra / while generating backedn …
URL: https://github.com/apache/knox/pull/142#issuecomment-533498373
Thanks @risdenk for the comments. I have refactored the code with a Base
test class. I had a quick look at how to implement Junit Parameterized test. In
my case, I need to parameterize setting up of GatewayConfig and starting of
Gateway Server which would be done repeatedly for both the test cases so not
much performance gain in terms of test case execution. Please check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 315573)
Time Spent: 3h (was: 2h 50m)
> For websocket connections, backend url generated is incorrect - has an extra
> '/' in path
> ----------------------------------------------------------------------------------------
>
> Key: KNOX-1996
> URL: https://issues.apache.org/jira/browse/KNOX-1996
> Project: Apache Knox
> Issue Type: Bug
> Components: Server
> Affects Versions: 1.0.0, 1.1.0, 1.2.0, 1.3.0
> Environment: HDP 3.1.0
> Reporter: Rajat Goel
> Assignee: Rajat Goel
> Priority: Major
> Fix For: 1.4.0
>
> Attachments: KNOX-1996.patch
>
> Time Spent: 3h
> Remaining Estimate: 0h
>
> {quote}{color:#000000}For websocket connections, while generating backend url
> in _org.apache.knox.gateway.websockets.GatewayWebsocketHandler_
> (_getMatchedBackendURL()_ API), Knox appends '_pathservice[1]_' to
> '_backend_' StringBuffer if Service url doesn't end with '/ws'. As a result,
> URI generated had an extra '/' eg:
> {color}{color:#000000}ws://{color}[rafd001-mst-01.cloud.in.guavus.com:11011//_sock/411/anq2kfzp/websocket|http://rafd001-mst-01.cloud.in.guavus.com:11011//_sock/411/anq2kfzp/websocket]{color:#000000}
> and my UI backend which uses SockJS lib was not responding for 2 minutes and
> eventually closing connection.{color}
> {color:#000000}Correct Url which should have been generated is:
> ws://[rafd001-mst-01.cloud.in.guavus.com:11011/_sock/411/anq2kfzp/websocket|http://rafd001-mst-01.cloud.in.guavus.com:11011//_sock/411/anq2kfzp/websocket]{color}
> {quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
