[
https://issues.apache.org/jira/browse/KNOX-1996?focusedWorklogId=320551&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-320551
]
ASF GitHub Bot logged work on KNOX-1996:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Sep/19 14:59
Start Date: 30/Sep/19 14:59
Worklog Time Spent: 10m
Work Description: moresandeep commented on pull request #142: KNOX-1996:
Adding changes to remove extra / while generating backedn …
URL: https://github.com/apache/knox/pull/142#discussion_r329595292
##########
File path:
gateway-server/src/test/java/org/apache/knox/gateway/websockets/WebsocketBackendUrlTest.java
##########
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.knox.gateway.websockets;
+
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.Test;
+
+import java.net.URI;
+import java.util.Locale;
+
+import org.eclipse.jetty.server.Server;
+import org.eclipse.jetty.server.ServerConnector;
+
+import static org.hamcrest.CoreMatchers.is;
+import static org.hamcrest.MatcherAssert.assertThat;
+
+/**
+ * A basic test that attempts to test the backedn url generated by gateway
proxy.
+ */
+public class WebsocketBackendUrlTest extends WebsocketEchoTestBase {
Review comment:
I get an NPE when I run the test via IDE, does it run for properly for you ?
`java.lang.NullPointerException
at
org.apache.knox.gateway.websockets.WebsocketBackendUrlTest.testWebsocketBackendUrl(WebsocketBackendUrlTest.java:70)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
at
com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
at
com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:47)
at
com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:242)
at
com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 320551)
Time Spent: 4h (was: 3h 50m)
> For websocket connections, backend url generated is incorrect - has an extra
> '/' in path
> ----------------------------------------------------------------------------------------
>
> Key: KNOX-1996
> URL: https://issues.apache.org/jira/browse/KNOX-1996
> Project: Apache Knox
> Issue Type: Bug
> Components: Server
> Affects Versions: 1.0.0, 1.1.0, 1.2.0, 1.3.0
> Environment: HDP 3.1.0
> Reporter: Rajat Goel
> Assignee: Rajat Goel
> Priority: Major
> Fix For: 1.4.0
>
> Attachments: KNOX-1996.patch
>
> Time Spent: 4h
> Remaining Estimate: 0h
>
> {quote}{color:#000000}For websocket connections, while generating backend url
> in _org.apache.knox.gateway.websockets.GatewayWebsocketHandler_
> (_getMatchedBackendURL()_ API), Knox appends '_pathservice[1]_' to
> '_backend_' StringBuffer if Service url doesn't end with '/ws'. As a result,
> URI generated had an extra '/' eg:
> {color}{color:#000000}ws://{color}[rafd001-mst-01.cloud.in.guavus.com:11011//_sock/411/anq2kfzp/websocket|http://rafd001-mst-01.cloud.in.guavus.com:11011//_sock/411/anq2kfzp/websocket]{color:#000000}
> and my UI backend which uses SockJS lib was not responding for 2 minutes and
> eventually closing connection.{color}
> {color:#000000}Correct Url which should have been generated is:
> ws://[rafd001-mst-01.cloud.in.guavus.com:11011/_sock/411/anq2kfzp/websocket|http://rafd001-mst-01.cloud.in.guavus.com:11011//_sock/411/anq2kfzp/websocket]{color}
> {quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
