[
https://issues.apache.org/jira/browse/KNOX-2024?focusedWorklogId=320486&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-320486
]
ASF GitHub Bot logged work on KNOX-2024:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Sep/19 13:18
Start Date: 30/Sep/19 13:18
Worklog Time Spent: 10m
Work Description: risdenk commented on pull request #160: KNOX-2024 -
KnoxShellTable - Case Insensitive Operations with Col Names
URL: https://github.com/apache/knox/pull/160#discussion_r329570173
##########
File path:
gateway-shell/src/main/java/org/apache/knox/gateway/shell/table/KnoxShellTableFilter.java
##########
@@ -32,7 +32,15 @@ public KnoxShellTableFilter table(KnoxShellTable table) {
}
public KnoxShellTableFilter name(String name) {
- index = tableToFilter == null ? -1 : tableToFilter.headers.indexOf(name);
+ for (int i = 0; i < tableToFilter.headers.size(); i++) {
+ if (tableToFilter.headers.get(i).equalsIgnoreCase(name)) {
+ index = i;
Review comment:
What is index used for outside of this method? Could there be an issue that
index is being updated and changed to -1 on no matches before switched back to
the right index?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 320486)
Time Spent: 50m (was: 40m)
> KnoxShellTable - Case Insensitive Operations with Col Names
> -----------------------------------------------------------
>
> Key: KNOX-2024
> URL: https://issues.apache.org/jira/browse/KNOX-2024
> Project: Apache Knox
> Issue Type: Improvement
> Components: KnoxShell
> Reporter: Larry McCay
> Assignee: Ljmiv
> Priority: Major
> Labels: noob
> Fix For: 1.4.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Filtering, sorting and selection operations accept "name" args but are
> currently case sensitive.
> These need to be changed to be case insensitive.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
