[
https://issues.apache.org/jira/browse/KNOX-2024?focusedWorklogId=321418&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-321418
]
ASF GitHub Bot logged work on KNOX-2024:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Oct/19 18:15
Start Date: 01/Oct/19 18:15
Worklog Time Spent: 10m
Work Description: lmccay4 commented on pull request #160: KNOX-2024 -
KnoxShellTable - Case Insensitive Operations with Col Names
URL: https://github.com/apache/knox/pull/160#discussion_r330201592
##########
File path:
gateway-shell/src/main/java/org/apache/knox/gateway/shell/table/KnoxShellTableFilter.java
##########
@@ -32,7 +32,15 @@ public KnoxShellTableFilter table(KnoxShellTable table) {
}
public KnoxShellTableFilter name(String name) {
- index = tableToFilter == null ? -1 : tableToFilter.headers.indexOf(name);
+ for (int i = 0; i < tableToFilter.headers.size(); i++) {
+ if (tableToFilter.headers.get(i).equalsIgnoreCase(name)) {
+ index = i;
Review comment:
I see your original concern, my bad. `index` is a member variable of the
filter class and only ever used in that one filter instance, not a global
variable. As for -1, that is the returned index when no matches exist, which
throws an exception.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 321418)
Time Spent: 1h 40m (was: 1.5h)
> KnoxShellTable - Case Insensitive Operations with Col Names
> -----------------------------------------------------------
>
> Key: KNOX-2024
> URL: https://issues.apache.org/jira/browse/KNOX-2024
> Project: Apache Knox
> Issue Type: Improvement
> Components: KnoxShell
> Reporter: Larry McCay
> Assignee: Ljmiv
> Priority: Major
> Labels: noob
> Fix For: 1.4.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Filtering, sorting and selection operations accept "name" args but are
> currently case sensitive.
> These need to be changed to be case insensitive.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
