risdenk commented on a change in pull request #169: KNOX-2056 - Adding Service
Definitions management into Admin UI
URL: https://github.com/apache/knox/pull/169#discussion_r339065741
##########
File path:
gateway-admin-ui/admin-ui/app/resource-detail/resource-detail.component.html
##########
@@ -551,3 +551,8 @@ <h4 class="modal-title">Discard {{getTitleSubject()}}
Changes</h4>
<div *ngIf="resourceType === 'Topologies'">
<app-topology-detail></app-topology-detail>
</div>
+
+<!-- Service Definition Details -->
+<div *ngIf="resourceType === 'Service Definitions'">
Review comment:
No idea what current HTML/JS coding standards are, but `Service Definitions`
as a type seems weird? Should it be one word? A unique identifier with a space
jumped out at me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
