[ 
https://issues.apache.org/jira/browse/KNOX-1842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16967143#comment-16967143
 ] 

Kevin Risden commented on KNOX-1842:
------------------------------------

So fun fact - rest-assured that we use doesn't give the ability to turn off the 
new http client normalization.
* https://stackoverflow.com/a/52722707/405798
* https://github.com/rest-assured/rest-assured/issues/497
* https://github.com/rest-assured/rest-assured/wiki/Usage#http-client-config

Without the ability to set the RequestConfig (which is only on the new 
HttpClient impls), that makes it impossible to turn off the url normalization. 

here is an example:
• test has for example the following url - abc/def////ghi
• rest assured httpclient sends the request to Knox
• restassured uses httpclient and the "normalization" - url becomes abc/def/ghi 
- it is broken here
• gateway receives abc/def/ghi
• gateway dispatches abc/def/ghi - this is where our HTTP client comes into play
• mock server receives abc/def/ghi
• mock server tries to compare to abc/def////ghi and blows up

So need to basically do a test without rest-assured to have more control over 
the httpclient.

> Upgrade httpclient to 4.5.10
> ----------------------------
>
>                 Key: KNOX-1842
>                 URL: https://issues.apache.org/jira/browse/KNOX-1842
>             Project: Apache Knox
>          Issue Type: Sub-task
>            Reporter: Kevin Risden
>            Assignee: Kevin Risden
>            Priority: Minor
>             Fix For: 1.4.0
>
>
> Upgrade httpclient 4.5.6 to 4.5.10



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to