risdenk commented on a change in pull request #178: KNOX-2071 - Configurable maximum token lifetime for TokenStateService URL: https://github.com/apache/knox/pull/178#discussion_r343169140
########## File path: gateway-service-knoxtoken/src/test/java/org/apache/knox/gateway/service/knoxtoken/TokenServiceResourceTest.java ########## @@ -23,6 +23,7 @@ import com.nimbusds.jose.JWSVerifier; import com.nimbusds.jose.crypto.RSASSASigner; import com.nimbusds.jose.crypto.RSASSAVerifier; +import org.apache.commons.lang3.tuple.Pair; Review comment: Hmm yea, I thought JDK 8 had a "Pair" class. Maybe https://docs.oracle.com/javase/8/docs/api/java/util/AbstractMap.SimpleImmutableEntry.html? JDK 9+ has https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/util/Map.html#entry(K,V) https://stackoverflow.com/questions/24328679/does-java-se-8-have-pairs-or-tuples ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
